Skip to content

Commit

Permalink
Fix raw data obs with all flagged tiles being rejected.
Browse files Browse the repository at this point in the history
These obs should be rejected by default, but if the user wants the input data
tile flags to be ignored, then these obs can be used.
  • Loading branch information
cjordan committed Sep 23, 2023
1 parent 475613e commit b31adb5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 4 deletions.
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@ Versioning](https://semver.org/spec/v2.0.0.html).
(not to be confused with the favoured SHAPELET2 component type).
- Some MWA raw data observations were not handled correctly due to a
floating-point error.
- MWA raw data observations with all flagged tiles weren't allowed to be used,
even with the explicit "ignore input data tile flags".

### Changed
- The performance of CPU visibility modelling has been dramatically improved.
Expand Down
3 changes: 0 additions & 3 deletions src/io/read/raw/error.rs
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,6 @@ pub(crate) enum RawReadError {
#[error("Got a tile flag {got}, but the biggest possible antenna index is {max}!")]
InvalidTileFlag { got: usize, max: usize },

#[error("All of this observation's tiles are flagged; cannot continue.")]
AllTilesFlagged,

#[error("All of this observation's coarse channels are deemed bad; cannot continue")]
NoGoodCoarseChannels,

Expand Down
2 changes: 1 addition & 1 deletion src/io/read/raw/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ impl RawDataReader {
let num_unflagged_tiles = total_num_tiles - tile_flags_set.len();
debug!("There are {} unflagged tiles", num_unflagged_tiles);
if num_unflagged_tiles == 0 {
return Err(RawReadError::AllTilesFlagged);
warn!("All of this observation's tiles are flagged");
}

// Check that the tile flags are sensible.
Expand Down

0 comments on commit b31adb5

Please sign in to comment.