Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added voltage download submission option. Fixes #12 #13

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

gsleap
Copy link
Member

@gsleap gsleap commented Jul 26, 2023

Hi folks,

My first PR for Giant Squid! This allows the submission of voltage jobs. NOTE the server will reject a request if you are not in the mwavcs or mwaops MWA ASVO pawsey group.

Cheers

Greg

@gsleap gsleap requested a review from d3v-null July 26, 2023 06:13
@codecov
Copy link

codecov bot commented Jul 26, 2023

Codecov Report

Merging #13 (2648813) into main (5821085) will increase coverage by 0.64%.
The diff coverage is 43.02%.

@@            Coverage Diff             @@
##             main      #13      +/-   ##
==========================================
+ Coverage   38.04%   38.68%   +0.64%     
==========================================
  Files           8        8              
  Lines        1033     1114      +81     
==========================================
+ Hits          393      431      +38     
- Misses        640      683      +43     
Files Changed Coverage Δ
src/asvo/error.rs 0.00% <ø> (ø)
src/bin/giant-squid.rs 0.32% <0.00%> (-0.06%) ⬇️
src/asvo/mod.rs 45.23% <86.04%> (+6.02%) ⬆️

... and 1 file with indirect coverage changes

@cjordan
Copy link
Contributor

cjordan commented Jul 26, 2023

I'm not really looking at giant-squid any more, but your PR looks good 👍 I trust you've tested this and it works to your sanctification. Maybe Dev would like to cast their eyes over the code, but I reckon you can merge and release as you please.

Copy link
Contributor

@d3v-null d3v-null left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks Greg!

@gsleap gsleap merged commit 2d4b14e into main Aug 1, 2023
10 checks passed
@gsleap gsleap deleted the voltage_job_support branch August 1, 2023 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants