Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Occam2d fixes #56

Merged
merged 4 commits into from
Oct 14, 2024
Merged

Occam2d fixes #56

merged 4 commits into from
Oct 14, 2024

Conversation

alkirkby
Copy link
Collaborator

@alkirkby alkirkby commented Oct 1, 2024

Various updates to Occam2d so that it works and gives correct results. Seems to be failing tests when building environment for testing. Not sure why.

@alkirkby
Copy link
Collaborator Author

alkirkby commented Oct 2, 2024

OK- got the env to load ok. Will look into failing tests.

@kujaku11
Copy link
Contributor

kujaku11 commented Oct 3, 2024

@alkirkby looks like we just need to change the number of significant digits in the test, maybe something like 5 sig figs.

Looks like the they are the tests test_mt_stations.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 24.44444% with 34 lines in your changes missing coverage. Please review.

Project coverage is 33.23%. Comparing base (d503d0a) to head (60d3368).
Report is 90 commits behind head on updates.

Files with missing lines Patch % Lines
mtpy/modeling/occam2d/regularization.py 6.25% 15 Missing ⚠️
mtpy/modeling/occam2d/mesh.py 0.00% 7 Missing ⚠️
mtpy/modeling/occam2d/model.py 33.33% 4 Missing ⚠️
mtpy/core/mt_data.py 0.00% 2 Missing ⚠️
mtpy/core/mt_stations.py 77.77% 2 Missing ⚠️
mtpy/modeling/occam2d/data.py 0.00% 2 Missing ⚠️
mtpy/modeling/occam2d/startup.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           updates      #56      +/-   ##
===========================================
+ Coverage    33.20%   33.23%   +0.03%     
===========================================
  Files          146      146              
  Lines        23966    24002      +36     
===========================================
+ Hits          7957     7978      +21     
- Misses       16009    16024      +15     
Flag Coverage Δ
tests 33.23% <24.44%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kujaku11
Copy link
Contributor

kujaku11 commented Oct 8, 2024

@alkirkby, I updated the tests so they pass.

@alkirkby
Copy link
Collaborator Author

alkirkby commented Oct 9, 2024

Awesome thank you @kujaku11 and sorry I didn't get to this. I did change some things in generate_profile so that the 0 point in the profile is a perpendicular projection of the first site, I hope that didn't break anything else.

@kujaku11 kujaku11 merged commit 41c9195 into updates Oct 14, 2024
5 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants