-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Occam2d fixes #56
Occam2d fixes #56
Conversation
…so that start is projected perpendicular from first site
OK- got the env to load ok. Will look into failing tests. |
@alkirkby looks like we just need to change the number of significant digits in the test, maybe something like 5 sig figs. Looks like the they are the tests test_mt_stations. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## updates #56 +/- ##
===========================================
+ Coverage 33.20% 33.23% +0.03%
===========================================
Files 146 146
Lines 23966 24002 +36
===========================================
+ Hits 7957 7978 +21
- Misses 16009 16024 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@alkirkby, I updated the tests so they pass. |
Awesome thank you @kujaku11 and sorry I didn't get to this. I did change some things in generate_profile so that the 0 point in the profile is a perpendicular projection of the first site, I hope that didn't break anything else. |
Various updates to Occam2d so that it works and gives correct results. Seems to be failing tests when building environment for testing. Not sure why.