Update akshara pulse tracker (rhythm extractor) and fix tool listing functions #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasgnuttall
requested changes
Feb 14, 2023
thomasgnuttall
requested changes
Feb 14, 2023
genisplaja
added a commit
that referenced
this pull request
Oct 23, 2023
…functions (#84) * update list tools, move akshara class to __init__ * update ipython version * downgrade ipython for python3.7 * fix write and add read csv * fix bug in melodia and add write csv in pitch extractors * remove prova.csv * remove unneded function * change to save_pitch and update read_csv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we basically move the akshara pulse tracker main class in the init (as done for the rest of the tools), which also makes the function
rhythm.list_tools()to properly work. Meanwhile, I have identified a small bug in alllist_tools()functions. This has been also fixed in this PR.