-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Kamavardini scale and fixed Svara to cent mapping #79
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Thanks @Prospekt42 for the contribution. I think also @thomasgnuttall that this is a good chance to fix the issue with pushing docs, which fails for the non-admin contributors. I'll take a look. In the meantime, @Prospekt42 feel free to merge :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missclicked :) Accepting the changes.
Great! Thanks! |
Hi @Prospekt42, sorry for the late reply...! Could you please update your branch with the latest changes in master and see if the error is gone and if you are allowed to merge? Thanks!! |
Hi @genisplaja , I just updated my branch with the latest changes in master. The error is gone, but it now says that first-time contributors need a maintainer to approve running workflows. It still isn't letting me merge the pull request either. |
@Prospekt42 workflows approved! How about merging now? |
@genisplaja, it's still not allowing me to merge :/ it still says that only people with write access can merge. Will it help if I also send a screenshot of the pull request page? |
Just gave you write access :) |
@genisplaja it worked! Thanks! I've merged the pull request. |
Added Kamavardini scale and fixed Svara to cent mapping
Hola guys,
This is my first tiny contribution to compIAM, and there are more to come!
I added the arohana and Avarohana of the Kamavardini ragam to the list of ragam scales, and I fixed an error in the Svara to cent mappings that had some typos.