Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(frontend): mission list team member layout and mutation #172

Merged
merged 1 commit into from
Jun 3, 2024
Merged

fix(frontend): mission list team member layout and mutation #172

merged 1 commit into from
Jun 3, 2024

Conversation

xtiannyeto
Copy link
Collaborator

  • Modify layout to add width 100% on stack item
  • Update mutation parameter, missionId: Number instead of string

@xtiannyeto
fix(frontend): mission list team member layout and mutation
82a8dd0 
 - Modify layout to add width 100% on stack item
 - Update mutation parameter, missionId: Number instead of string
@github-actions GitHub Actions
Copy link

github-actions bot commented Jun 3, 2024

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 66.14% (🎯 50%) 1424 / 2153
🟢 Statements 66.83% (🎯 50%) 1481 / 2216
🟢 Functions 64.92% (🎯 50%) 372 / 573
🟢 Branches 59.01% (🎯 50%) 635 / 1076
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
frontend/src/pam/mission/crew/mission-crew-member-list.tsx 100% 100% 100% 100%
frontend/src/pam/mission/crew/mission-crew.tsx 80.95% 61.53% 87.5% 82.85% 82, 82-83, 87, 87-90
frontend/src/pam/mission/crew/use-add-update-mission-crew.tsx 100% 100% 100% 100%
Generated in workflow #566

lwih
lwih approved these changes Jun 3, 2024
View reviewed changes
Copy link
Collaborator

@lwih lwih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

c'est top

frontend/src/pam/mission/crew/mission-crew.tsx
@@ -84,7 +84,8 @@ const MissionCrew: React.FC<MissionCrewProps> = () => {
}

const handleSubmitForm = async (data: AddOrUpdateMissionCrewInput) => {
const crew = { ...data, missionId }
if (!missionId) return
const crew = { ...data, missionId: Number(missionId) }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je connaissais pas la méthode Number(xxx), c'est cool.
c'est plus digeste que parseInt(missionId, 10)

@xtiannyeto xtiannyeto merged commit ed56517 into main Jun 3, 2024
9 of 10 checks passed
@xtiannyeto xtiannyeto deleted the fix/layout-add-team-member-update branch June 3, 2024 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lwih lwih lwih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xtiannyeto @lwih