[Tableau de bord] Ajout des ancres et retour aux sections #1865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
maximeperraultdev
commented
Nov 18, 2024
•
maximeperraultdev
commented
- Resolve Ajouter des ancres permettant un retour aux sections #1801
maximeperraultdev
force-pushed
the
maxime/dashboard/add_anchors_to_section
branch
2 times, most recently
from
1e11012 to
ecdf9da
Compare
claire2212
reviewed
Nov 19, 2024
There was a problem hiding this comment.
Remarque globale:
-Avec le strict mode activé les dashboards ne s'affiche plus à cause du useEffect ligne 184 dans le DashboardForm
- Je me demande s'il ne faudrait pas séparer les trois colonnes dans
DashboardFormdans trois fichiers, t'en penses quoi? (pas forcément à faire dans cette pr)
frontend/src/features/Dashboard/components/DashboardForm/Amps/index.tsx
Outdated
Show resolved
Hide resolved
maximeperraultdev
force-pushed
the
maxime/dashboard/add_anchors_to_section
branch
3 times, most recently
from
df65c57 to
0c2328f
Compare
claire2212
approved these changes
Nov 19, 2024
maximeperraultdev
force-pushed
the
maxime/dashboard/add_anchors_to_section
branch
from
0c2328f to
9f4a2d8
Compare
maximeperraultdev
force-pushed
the
maxime/dashboard/add_anchors_to_section
branch
from
9f4a2d8 to
8364ab2
Compare
|
maximeperraultdev
deleted the
maxime/dashboard/add_anchors_to_section
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.