Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dev threading fixes #2755

Merged
merged 4 commits into from
Mar 11, 2024
Merged

dev threading fixes #2755

merged 4 commits into from
Mar 11, 2024

Conversation

jdtournier
Copy link
Member

@jdtournier jdtournier commented Nov 22, 2023

Having some fun with Thread Sanitizer & clang-tidy...

@jdtournier jdtournier added the bug label Nov 22, 2023
@jdtournier jdtournier self-assigned this Nov 22, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

core/algo/threaded_loop.h Outdated Show resolved Hide resolved
core/progressbar.h Outdated Show resolved Hide resolved
core/progressbar.h Outdated Show resolved Hide resolved
core/progressbar.h Outdated Show resolved Hide resolved
core/progressbar.h Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

core/algo/threaded_loop.h Outdated Show resolved Hide resolved
@daljit46 daljit46 force-pushed the dev_threading_fixes branch from cb4eb6f to 63e1847 Compare November 22, 2023 13:09
Copy link

clang-tidy review says "All clean, LGTM! 👍"

@daljit46 daljit46 force-pushed the dev_threading_fixes branch from 63e1847 to 9b77ef1 Compare November 22, 2023 13:52
Copy link

clang-tidy review says "All clean, LGTM! 👍"

core/algo/threaded_loop.h Outdated Show resolved Hide resolved
@daljit46
Copy link
Member

daljit46 commented Feb 2, 2024

I've now introduced a MutexProtected class as part of this PR, following #2778. This can be used to better protect resources across threads.

core/algo/threaded_loop.h Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

core/algo/threaded_loop.h Show resolved Hide resolved
core/algo/threaded_loop.h Show resolved Hide resolved
core/mutexprotected.h Show resolved Hide resolved
@daljit46 daljit46 force-pushed the dev_threading_fixes branch from 3e0f6fe to 8a80e86 Compare February 19, 2024 19:39
@daljit46 daljit46 force-pushed the dev_threading_fixes branch from 8a80e86 to b5db27f Compare February 20, 2024 10:26
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

core/algo/threaded_loop.h Show resolved Hide resolved
core/algo/threaded_loop.h Show resolved Hide resolved
@daljit46 daljit46 force-pushed the dev_threading_fixes branch from b5db27f to 6f66987 Compare February 21, 2024 12:09
@daljit46 daljit46 force-pushed the dev_threading_fixes branch from 6f66987 to f7e74ab Compare March 8, 2024 17:55
@daljit46 daljit46 marked this pull request as ready for review March 11, 2024 14:23
@daljit46 daljit46 merged commit afa6e4f into dev Mar 11, 2024
6 checks passed
@daljit46 daljit46 deleted the dev_threading_fixes branch March 11, 2024 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants