Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remapping from MPAS vertices #906

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Sep 26, 2022

This merge adds support for remapping from MPAS variables at vertices to comparison grids.

To make sure mapping files are unique, _vertices is appended to the name of the MPAS mesh if it maps from vertices instead of cells. We will eventually want to cache these new mapping files just like we do for the cell versions and compute them in compass with new meshes along with the existing mapping files.

To remap variables on vertices, you need to create a RemapMpasClimatologySubtask object with vertices=True as a parameter.

@xylar xylar requested a review from akturner September 26, 2022 23:43
@xylar xylar self-assigned this Sep 26, 2022
@xylar
Copy link
Collaborator Author

xylar commented Sep 26, 2022

@akturner, this worked for me when I switched the barotropic streamfunction to be computed on vertices, rather than cells, see:
xylar@5f6ea2f

If you rebase your branch onto this one, you should be able to just add vertices=True when you call the constructor for RemapMpasClimatologySubtask.

Copy link
Collaborator

@anirban89 anirban89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works for me

@xylar xylar removed the request for review from akturner September 28, 2022 21:33
@xylar
Copy link
Collaborator Author

xylar commented Sep 28, 2022

Testing

We have rebased #898 onto this branch and are using the barotropic streamfunction computed at vertices for all plots. Everything seems to be working well there.

@xylar xylar merged commit 2233dd7 into MPAS-Dev:develop Sep 28, 2022
@xylar xylar deleted the remap_from_vertices branch September 28, 2022 21:35
@xylar
Copy link
Collaborator Author

xylar commented Sep 28, 2022

@anirban89, thanks very much for reviewing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants