Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up ClimatologyMapOHCAnomaly #894

Merged
merged 1 commit into from
Sep 21, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Sep 21, 2022

In order to be a reference analysis task for the tutorial, ClimatologyMapOHCAnomaly and its subtask
RemapMpasOHCClimatology have been cleaned up to:

  • follow the PEP8 style guide
  • fix docstrings
  • use f-strings instead of format calls
  • simplify super() calls
  • keep lines under 79 characters where sensible

In order to be a reference analaysis task for the tutorial,
ClimatologyMapOHCAnomaly and its subtask
RemapMpasOHCClimatology have been cleaned up to:
* follow the PEP8 style guide
* fix docstrings
* use f-strings instead of format calls
* simplify super() calls
* keep lines under 79 characters where sensible
@xylar xylar added the clean up label Sep 21, 2022
@xylar xylar self-assigned this Sep 21, 2022
@xylar
Copy link
Collaborator Author

xylar commented Sep 21, 2022

Testing

The test suite on Anvil worked as expected. Results are here:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/anvil/clean_up_climatology_map_ohc_anomaly

image

@xylar xylar merged commit d91a627 into MPAS-Dev:develop Sep 21, 2022
@xylar xylar deleted the clean_up_climatology_map_ohc_anomaly branch September 21, 2022 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant