fix(utl-hpc.dfn): fix flopy subpackage metadata #2182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wpbonelli : let me know if there are any implications for the Fortran side of this. Or, if it helps you to change anything there. |
|
Thanks @mjr-deltares I think this has no bearing on the fortran side, just a flopy issue. But it would be good to have your feedback on our re-imagining of the DFN format, maybe when we meet in Boulder? |
|
I think, given the passing tests, that this won't break flopy.. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think the final term here should be
hpc_data, to follow the convention used for other subpackages and produce the generated files as they currently appear in flopy — at least assuming the same code is to handle all subpackages. Seems like there is inconsistent handling currently, depending whether they are attached to simulation or to a model or package.