Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(prt): skip release times falling outside tdis #2127

Merged
merged 6 commits into from
Jan 6, 2025

Conversation

wpbonelli
Copy link
Contributor

@wpbonelli wpbonelli commented Jan 6, 2025

Mentioned in the discussion in #2125, skip release times before simulation start, and after simulation end if no extended tracking.


Checklist of items for pull request

  • Replaced section above with description of pull request
  • Referenced issue or pull request Wrong time unit usage in PRP package #2125
  • Formatted new and modified Fortran source files with fprettify
  • Updated develop.tex with a plain-language description of the bug fix, change, feature; required for changes that may affect users
  • Removed checklist items not relevant to this pull request

@wpbonelli wpbonelli added this to the 6.6.1 milestone Jan 6, 2025
@wpbonelli wpbonelli added the bug label Jan 6, 2025
@wpbonelli wpbonelli marked this pull request as ready for review January 6, 2025 19:53
Copy link
Contributor

@aprovost-usgs aprovost-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Just one suggested tweak to the wording.

doc/ReleaseNotes/develop.tex Show resolved Hide resolved
@wpbonelli wpbonelli merged commit 8ef3ad7 into MODFLOW-USGS:develop Jan 6, 2025
6 checks passed
@wpbonelli wpbonelli deleted the prt-release branch January 6, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants