Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use explicit parameter passing on subclass __init__.py #29

Closed
csala opened this issue Apr 13, 2018 · 1 comment
Closed

Use explicit parameter passing on subclass __init__.py #29

csala opened this issue Apr 13, 2018 · 1 comment
Assignees
@csala
Milestone
v0.2.0

Comments

@csala
Copy link
Contributor

csala commented Apr 13, 2018

Several subclasses are getting initialization arguments in the __init__ method by popping them from kwargs.

This should be made explicit by directly setting those values as __init__ arguments.
@csala csala changed the title Use explicit parameter passing on suclass __init__.py Use explicit parameter passing on subclass __init__.py Apr 13, 2018
csala added a commit that referenced this issue Apr 24, 2018
@csala
Resolve Issue #29: Make args explicit in __init__ methods
824c3c2
lauragustafson added a commit that referenced this issue Apr 25, 2018
@lauragustafson
Merge pull request #39 from HDI-Project/GH_29_explicit_parameter_passing
7dab863 
Resolve Issue #29: Make args explicit in __init__ methods
@csala csala self-assigned this Apr 26, 2018
@csala
Copy link
Contributor Author

csala commented Apr 26, 2018

Done in PR #39

@csala csala closed this as completed Apr 26, 2018
@csala csala added this to the v0.2.0 milestone May 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@csala csala

Labels
None yet
Projects
None yet
Milestone
v0.2.0
Development

No branches or pull requests
1 participant
@csala