Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Layer names refer to LayerKeys #34

Merged
merged 5 commits into from
Mar 4, 2025

Conversation

GoldenZephyr
Copy link
Contributor

No description provided.

@nathanhhughes nathanhhughes requested a review from yunzc March 4, 2025 21:20
@nathanhhughes
Copy link
Collaborator

@yunzc This is the implementation of what we were chatting about earlier (where layer names now refer to LayerKey, not LayerId). The implication on the Hydra side is that you have to do something like:

const auto layer_id = graph.getLayerKey(DsgLayers::AGENTS)->layer;
const auto& layer = graph.getLayer(layer_id, 'a');

instead of

const auto& layer = graph.getLayer(DsgLayers::AGENTS, 'a');

to get the agents. Everything else you can just drop the extra partition ID if you're using a name. We'll probably merge this in soon rather than later, but lmk if you have thoughts

Copy link
Member

@yunzc yunzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeup, looks good to me!

@nathanhhughes nathanhhughes merged commit 3ad1031 into develop Mar 4, 2025
4 checks passed
@nathanhhughes nathanhhughes deleted the feature/spark_dsg_layer_key branch March 4, 2025 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants