-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IO bomb: #20
IO bomb: #20
Conversation
…oml. tweaks to accommodate throughout
…and pari, fixed bug in save_model()
….inc bugs. added CSV dep (i think)
… tasopt.jl to files, moved fns to par_array_opers
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #20 +/- ##
==========================================
+ Coverage 73.10% 73.84% +0.74%
==========================================
Files 64 68 +4
Lines 12373 12906 +533
==========================================
+ Hits 9045 9531 +486
- Misses 3328 3375 +47 ☔ View full report in Codecov by Sentry. |
@argonaut22 I just pulled in another PR #18 which have caused a few merge conflicts. Could you please resolve these? |
remove use of unnecessary functions
removed unnecessary `global`
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this Jonas! Looks pretty great overall! ✨ Left a few minor comments!
aircraft
save_model
to save to output readable toml's a laread_input
read_input
to handle multi-mission and multi-point specspar_array_operations.jl
for convenient array manipulations (e.g.,array2nestedvector()
)read_mdl()
andread_jl()
inread_externals.jl
output_csv()
. able to specify flight points, missions, par_array indices, to be written to csv. has logic for appending multiple aircraft to a single csv if outputs are consistent.aircraft
struct:sized = [true/false]
as a sizing flag