Add Whitelisting Features to allow some external conntections #4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear MISP-Guard maintainers,
I would like to submit a pull request addressing the need to allow external MISP feed connections while maintaining MISP-Guard's security posture.
Motivation
MISP-Guard currently blocks all connections to and from unknown sources by default, which is an important security measure. However, many users rely on external MISP feeds to improve their threat intelligence. Therefore, it should be possible to whitelist URLs and domains so that feeds and MISPGuard can be used at the same time.
Proposed Changes
I have added a new feature to MISP-Guard that allows users to define a whitelist of trusted external MISP feed URLs and domains. Any connection request from a server configured in
instances_host_mapping
to one of the entries in this whitelist will be allowed, while connections from unknown sources will still be blocked.The changes include:
urls
anddomains
. With the help of json arrays, users can add their MISP-Feeds to this list for whitelisting.pytest
suite to ensure correctness and security of changes.Conclusion
I believe this feature will enhance the usability of MISP-Guard for users who rely on external MISP feeds. It strikes a balance between security and flexibility, allowing connections to known and trusted sources while maintaining the default security level.
I look forward to your feedback and am open to making any necessary adjustments based on your review. Thanks for considering this pull request.
Sincerely,
sva-mk