-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add optional parameter frequency_dimension across wave.resource #336
Conversation
@akeeste I wrote a script to see if this was improving the testing time and it does not appear to be making much difference. Is the purpose of this to address #331 or just to make the code more consistent?
|
@ssolson This PR doesn't yet address the underlying xarray slowdown, but it enables a workaround. The wave functions can currently be sped up by inputting xarray formats instead of pandas. However the parameter Most of the examples are still using pandas so this workaround is not utilized. Upcoming PRs #348 and after will address the underlying slowdown. |
From our discussion this test addresses the slowness by allowing a workaround but does not solve the slowness. Additional PR to follow for full issue. |
This PR makes the xarray work in wave.resource more consistent by adding the optional parameter
frequency_dimension
to functions likesignificant_wave_height
that then pass the parameter tofrequency_moment
.This is an immediate speed fix for #331 by allowing xarray formats to be passed to all relevant wave.resource functions