Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MESMER-X: Test distrib_cov #540

Merged
merged 16 commits into from
Oct 19, 2024
Merged

MESMER-X: Test distrib_cov #540

merged 16 commits into from
Oct 19, 2024

Conversation

veni-vidi-vici-dormivi
Copy link
Collaborator

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi commented Oct 3, 2024 •
edited
Loading

  • Tests added
  • Fully documented, including CHANGELOG.rst

@codecov Codecov
Copy link

codecov bot commented Oct 3, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.74%. Comparing base (72d2fd9) to head (765e18d).
Report is 7 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #540      +/-   ##
==========================================
+ Coverage   62.00%   62.74%   +0.74%     
==========================================
  Files          50       50              
  Lines        3561     3554       -7     
==========================================
+ Hits         2208     2230      +22     
+ Misses       1353     1324      -29
Flag Coverage Δ
unittests 62.74% <100.00%> (+0.74%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mathause
mathause approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks that looks good.

mesmer/mesmer_x/train_l_distrib_mesmerx.py Show resolved Hide resolved
mesmer/mesmer_x/train_l_distrib_mesmerx.py Outdated Show resolved Hide resolved
mesmer/mesmer_x/train_l_distrib_mesmerx.py Show resolved Hide resolved
mesmer/mesmer_x/train_l_distrib_mesmerx.py Outdated Show resolved Hide resolved
tests/unit/test_mesmer_x_distrib_cov.py Outdated Show resolved Hide resolved
tests/unit/test_mesmer_x_distrib_cov.py Outdated Show resolved Hide resolved
tests/unit/test_mesmer_x_distrib_cov.py Outdated Show resolved Hide resolved
tests/unit/test_mesmer_x_distrib_cov.py Outdated Show resolved Hide resolved
tests/unit/test_mesmer_x_distrib_cov.py Show resolved Hide resolved
@veni-vidi-vici-dormivi
Copy link
Collaborator Author

Ahh sorry, this is not at all done yet, I just pushed it to get the coverage report 😅

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi marked this pull request as draft October 4, 2024 07:47
@mathause
Copy link
Member

mathause commented Oct 4, 2024

Ahh sorry, this is not at all done yet, I just pushed it to get the coverage report 😅

Ahh well looks good already 😉

@veni-vidi-vici-dormivi @mathause
Update mesmer/mesmer_x/train_l_distrib_mesmerx.py
608c8cd 
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
@veni-vidi-vici-dormivi @mathause
Update mesmer/mesmer_x/train_l_distrib_mesmerx.py
6e4fde9 
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
@veni-vidi-vici-dormivi @mathause
Update tests/unit/test_mesmer_x_distrib_cov.py
74da59a 
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
@veni-vidi-vici-dormivi @mathause
Update tests/unit/test_mesmer_x_distrib_cov.py
2170d61 
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
@veni-vidi-vici-dormivi veni-vidi-vici-dormivi marked this pull request as ready for review October 19, 2024 09:21
@veni-vidi-vici-dormivi
Copy link
Collaborator Author

veni-vidi-vici-dormivi commented Oct 19, 2024 •
edited
Loading

@mathause, I added two tests for the weighting but only very basic ones. I am merging without another review and we can change something afterwards if we want to.

@veni-vidi-vici-dormivi veni-vidi-vici-dormivi merged commit 4d44150 into MESMER-group:main Oct 19, 2024
9 checks passed
@veni-vidi-vici-dormivi veni-vidi-vici-dormivi deleted the test_distrib_cov branch October 19, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mathause mathause mathause approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@veni-vidi-vici-dormivi @mathause