Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expression: split out evaluate_params #539

Merged
merged 6 commits into from
Oct 10, 2024

Conversation

mathause
Copy link
Member

@mathause mathause commented Oct 3, 2024

This creates a separate method to evaluate_params - so we don't necessarily create the frozen distribution. E.g. if we only need params["loc"] we can save the slow creation of the distribution.

This saves about 1-2 minutes on the tests already (about 20% - 25%).

Only a draft PR for now

@mathause mathause changed the title Expression split out evaluate_params Expression: split out evaluate_params Oct 3, 2024
@mathause mathause changed the title Expression: split out evaluate_params Expression: split out evaluate_params Oct 3, 2024
Copy link

codecov bot commented Oct 3, 2024

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 61.93%. Comparing base (685a5fd) to head (a7de4cb).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
mesmer/mesmer_x/train_utils_mesmerx.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #539      +/-   ##
==========================================
+ Coverage   61.89%   61.93%   +0.03%     
==========================================
  Files          50       50              
  Lines        3551     3554       +3     
==========================================
+ Hits         2198     2201       +3     
  Misses       1353     1353              
Flag Coverage Δ
unittests 61.93% <95.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause mathause marked this pull request as ready for review October 8, 2024 09:24
mesmer/mesmer_x/train_l_distrib_mesmerx.py Show resolved Hide resolved
mesmer/mesmer_x/train_l_distrib_mesmerx.py Outdated Show resolved Hide resolved
mesmer/mesmer_x/train_utils_mesmerx.py Outdated Show resolved Hide resolved
mesmer/mesmer_x/train_utils_mesmerx.py Show resolved Hide resolved
Copy link
Member Author

@mathause mathause left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

mesmer/mesmer_x/train_utils_mesmerx.py Show resolved Hide resolved
mesmer/mesmer_x/train_utils_mesmerx.py Outdated Show resolved Hide resolved
Co-authored-by: Victoria <112418493+veni-vidi-vici-dormivi@users.noreply.github.com>
@mathause mathause merged commit 4c48344 into MESMER-group:main Oct 10, 2024
9 checks passed
@mathause mathause deleted the expr_separate_get_params branch October 10, 2024 16:37
@mathause
Copy link
Member Author

@l-pierini with this change merged you should see a performance improvement for the fitting (more to come but I don't know when)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants