-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement DataTree as data structure #537
base: main
Are you sure you want to change the base?
Implement DataTree as data structure #537
Conversation
Unfortunately filefinder is not on conda - it's not even on pypi. The problem is that there is already a package with the same name on pypi - so I wasn't sure what to do. We can either work on getting it published (under another name) - or install it from github. |
Hm I see... What about |
https://github.com/C2SM/pyvis/blob/f7e509b9627d36cb09d4eee9ed1f3a84c6eeadda/environment.yml#L42 (using |
I think having to manually update it is fine, since we would be the ones updating filefinder. |
Yes, that's also my preferred option (could have mentioned that above...) |
|
forgot to mention: we can make |
Yes indeed, it is available since v2024.05. We are currently requiring at least v2023.07. Should I try with v2024.05? |
Sorry, what is this in reference to? |
I first thought we could support both - but on second thought I don't think it's worth it, so yes.
The list of issues that are closed by this PR - see the side bar |
and by the way: awesome 👍 |
Ah the pydata/xarray@18e5c87#diff-66d415f4d4a5d0969b40e35b86cbf67612bc3b88c7f02957a550f12df7e0e14eR19-R24 Before that we would need to import it from |
As discussed - in this case it does not make sense to require |
We use bash as shell on all 3 OS - it might be possible that we can get it to work on another shell on windows. But that might bring other problems with it. Anyways as discussed I will test that locally on my windows laptop and see if I can reproduce the problem. |
I can reproduce locally. Looks like that could be mamba-org/mamba#3467. But then I think we had the same error for micromamba < 2.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a first look and added some comments. It's too big to really understand everything but think it's going in the right direction.
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
Co-authored-by: Mathias Hauser <mathause@users.noreply.github.com>
We switch to
datatree
as high level data structure. We want to use aDataTree
to holdxr.Datasets
of each scenario. TheDataset
holds the members.CHANGELOG.rst
I'm sorry for the large PR but it wasn't a priori clear to me how to split it into smaller ones, maybe I will still do it retrospectively. I hope we don't lose sight of the forest for all the trees. 🌳 🌳