Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort . && black . && flake8
CHANGELOG.rst
I was playing around with #109 when I noticed some tests randomly failing. Took me too long what's going wrong. Writing a test for this would be a pain...
One thing I noticed - the way it is set up, we select
AROrder = 1
for the following situation:arr.quantile(q=0.5, method="nearest")
over the scenarios selects[1, 2]
and from this we select 1. (However, rounding up is no better, because then we could end up selecting 2 for (3 x 1 and 1 x 2). I may have to open an issue for this. Maybe it's also only relevant in this artificial scenario...