lowess: n_steps and use_coords #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathause
commented
Sep 7, 2023
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #285 +/- ##
==========================================
+ Coverage 86.39% 86.54% +0.15%
==========================================
Files 38 38
Lines 1543 1553 +10
==========================================
+ Hits 1333 1344 +11
+ Misses 210 209 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
isort . && black . && flake8CHANGELOG.rstThis adds some changes to
mesmer.stats.smoothing.lowess:n_stepskeyword, which can be used instead offrac(as this is used in mesmer)use_coords_as_xtouse_coordsuse_coords=Trueto use coords as x-values per default. For datetime coords this will have to be set toFalse- this is a bit unfortunate (because we will mostly use it for that). However, it's the right thing to do - we want to be explicit about not using the coords (important when they are not equally spaced).