Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move regionmaskcompat to core #275

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

mathause
Copy link
Member

@mathause mathause commented Sep 4, 2023

Moves regionmask.py to core to mark that we want to keep this in (until it is included in regionmask). Not exposed as top level module (only in mesmer.core) as the functionality is only used internally.

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (4e2b408) 86.48% compared to head (1e0f792) 86.48%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #275   +/-   ##
=======================================
  Coverage   86.48%   86.48%           
=======================================
  Files          38       38           
  Lines        1547     1547           
=======================================
  Hits         1338     1338           
  Misses        209      209           
Flag Coverage Δ
unittests 86.48% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mesmer/core/regionmaskcompat.py 95.45% <ø> (ø)
mesmer/core/mask.py 100.00% <100.00%> (ø)
mesmer/io/load_constant_files.py 95.91% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause mathause merged commit 4b66b70 into MESMER-group:main Sep 4, 2023
6 checks passed
@mathause mathause deleted the move_regionmaskcompat branch September 4, 2023 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant