Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grid_wrap: roundtrip tests #273

Merged
merged 2 commits into from
Sep 4, 2023

Conversation

mathause
Copy link
Member

@mathause mathause commented Sep 4, 2023

Note that the wrap functions do not strictly round trip data that is outside the -180..180/ 0..360 range.

  • Closes #xxx
  • Tests added
  • Passes isort . && black . && flake8
  • Fully documented, including CHANGELOG.rst

@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Patch coverage: 75.00% and project coverage change: +0.16% 🎉

Comparison is base (0232bd5) 86.31% compared to head (46007a9) 86.48%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #273      +/-   ##
==========================================
+ Coverage   86.31%   86.48%   +0.16%     
==========================================
  Files          39       39              
  Lines        1549     1546       -3     
==========================================
  Hits         1337     1337              
+ Misses        212      209       -3     
Flag Coverage Δ
unittests 86.48% <75.00%> (+0.16%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
mesmer/io/_load_cmipng.py 80.64% <75.00%> (+1.90%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mathause
Copy link
Member Author

mathause commented Sep 4, 2023

I think the failed rtd build is spurious - merging.

@mathause mathause merged commit 0412308 into MESMER-group:main Sep 4, 2023
6 checks passed
@mathause mathause deleted the grid_wrap_roundtrip_test branch September 4, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant