Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move v0 code to own folder #262

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mathause
Copy link
Member

This illustrates how we could move all code from v0 to it's own folder without disrupting the usage of the project. This is not something I want to do right now but wanted to have here for reference. Obviously the other folders would need to be moved as well.

Another option would be to keep packages = find:, add legacy_mesmer/__init__.py, add from legacy_mesmer import calibrate_mesmer to mesmer/__init__.py. However, from mesmer.calibrate_mesmer import train_gt will then fail.

  • Closes #xxx
  • Tests added
  • Passes isort . && black . && flake8
  • Fully documented, including CHANGELOG.rst

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.95 ⚠️

Comparison is base (79c495c) 86.24% compared to head (4410eb7) 84.29%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #262      +/-   ##
==========================================
- Coverage   86.24%   84.29%   -1.95%     
==========================================
  Files          38       31       -7     
  Lines        1512     1089     -423     
==========================================
- Hits         1304      918     -386     
+ Misses        208      171      -37     
Flag Coverage Δ
unittests 84.29% <ø> (-1.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mathause mathause modified the milestones: v0.11.0, v0.10.0 Sep 27, 2023
@mathause
Copy link
Member Author

This will happen after v0.9.0 and before v1.0.0 (have to decide if in v0.10.0 or in v0.11.0)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant