Skip to content

Commit

Permalink
powell
Browse files Browse the repository at this point in the history
  • Loading branch information
veni-vidi-vici-dormivi committed Aug 30, 2024
1 parent 0f0f66c commit 0df1b71
Show file tree
Hide file tree
Showing 4 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion mesmer/stats/_power_transformer.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ def _neg_log_likelihood(coeffs):
first_guess = np.array([1, 0])

xi_0, xi_1 = minimize(
_neg_log_likelihood, x0=first_guess, bounds=bounds, method="L-BFGS-B", jac="cs"
_neg_log_likelihood, x0=first_guess, bounds=bounds, method="Powell"
).x

return xi_0, xi_1
Expand Down
Binary file modified tests/test-data/output/tas/mon/test-mesmer_m-params.nc
Binary file not shown.
Binary file not shown.
2 changes: 1 addition & 1 deletion tests/unit/test_power_transformer.py
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ def test_yeo_johnson_optimize_lambda_np_normal():
np.testing.assert_allclose(result, expected, atol=1e-2)

# to test numerical stability
expected_exact = np.array([9.976913e-01, -1.998520e-05])
expected_exact = np.array([9.976784e-01, -6.410572e-07])
np.testing.assert_allclose(result, expected_exact, atol=1e-7)


Expand Down

0 comments on commit 0df1b71

Please sign in to comment.