Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken cinput #66

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Conversation

giovannipozzobon
Copy link
Contributor

@giovannipozzobon giovannipozzobon commented Sep 10, 2024

Checklist

Thanks a lot for your contribution!
Please tick off the following:

  • Tests run successfully (i.e. make test)
    • using the CC65 compiler
    • using the LLVM/Clang compiler
  • Doxygen style tags are used for public API
  • Source code is properly formatted; run e.g. clang-format -i <file>
  • I agree to the License of this repository

@mlund
Copy link
Collaborator

mlund commented Sep 10, 2024

Closes #65.

Copy link
Collaborator

@mlund mlund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. The main motivation for not including the range-guard in cputsxy() is to avoid needless check on known non-zero strings. I am here assuming that most calls to cputsxy() are with non-empty strings.

@mlund mlund linked an issue Sep 10, 2024 that may be closed by this pull request
@mlund mlund added the bug Something isn't working label Sep 11, 2024
@mlund mlund changed the title Issue #65 Problem with cinput Fix broken cinput Sep 11, 2024
@mlund mlund merged commit 95dbc22 into MEGA65:development Sep 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with cinput
2 participants