Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Add jinja2 version pin as workaround #870

Merged
merged 1 commit into from
Apr 13, 2022
Merged

[FIX] Add jinja2 version pin as workaround #870

merged 1 commit into from
Apr 13, 2022

Conversation

jbteves
Copy link
Collaborator

@jbteves jbteves commented Apr 4, 2022

Closes #869 .

Changes proposed in this pull request:

  • Pins jinja2 version as a workaround

@jbteves jbteves changed the title Add jinja2 version pin as workaround [FIX] Add jinja2 version pin as workaround Apr 4, 2022
@jbteves jbteves requested a review from handwerkerd April 4, 2022 18:38
@jbteves
Copy link
Collaborator Author

jbteves commented Apr 4, 2022

Can whomever reviews this please verify that it works with a fresh conda env?

@codecov
Copy link

codecov bot commented Apr 4, 2022

Codecov Report

Merging #870 (6ddccaf) into main (f42ba63) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #870   +/-   ##
=======================================
  Coverage   93.10%   93.10%           
=======================================
  Files          27       27           
  Lines        2219     2219           
=======================================
  Hits         2066     2066           
  Misses        153      153           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f42ba63...6ddccaf. Read the comment docs.

Copy link
Member

@tsalo tsalo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I was able to reproduce the bug. For posterity, here's the code I used:

conda create --name tedenv python=3.8 pip
conda activate tedenv
pip install tedana==0.0.11

# visited https://osf.io/9c42e/download to download 5-echo test data
# then untarred it in my Downloads folder
cd Downloads/five_echo

tedana -d p06.SBJ01_S09_Task11_e1.sm.nii.gz p06.SBJ01_S09_Task11_e2.sm.nii.gz p06.SBJ01_S09_Task11_e3.sm.nii.gz p06.SBJ01_S09_Task11_e4.sm.nii.gz p06.SBJ01_S09_Task11_e5.sm.nii.gz -e 15.4 29.7 44.0 58.3 72.6 --out-dir out/
# failed

pip install jinja2==3.0.1

tedana -d p06.SBJ01_S09_Task11_e1.sm.nii.gz p06.SBJ01_S09_Task11_e2.sm.nii.gz p06.SBJ01_S09_Task11_e3.sm.nii.gz p06.SBJ01_S09_Task11_e4.sm.nii.gz p06.SBJ01_S09_Task11_e5.sm.nii.gz -e 15.4 29.7 44.0 58.3 72.6 --out-dir out/
# succeeded!

@jbteves
Copy link
Collaborator Author

jbteves commented Apr 4, 2022

Thanks for that. You can actually reproduce with tedana -h since it's an import fail. Did you happen to try installing and running from the tip of this branch?

Copy link
Member

@handwerkerd handwerkerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finally found a chance to test. LGTM.

@jbteves jbteves merged commit 863304b into ME-ICA:main Apr 13, 2022
@jbteves jbteves deleted the pin_jinja branch April 13, 2022 19:56
@effigies effigies mentioned this pull request Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markup not found when running pip-installed tedana
3 participants