-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP, ENH] Add ability to read surface .gii files #22
Merged
Merged
Changes from 13 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
628bf64
[STY] Mostly stylistic, a few enhancements...
rmarkello cdc8cf0
[FIX] Screwed up nibabel import
rmarkello a94692b
[RF] Breaks everything; working to add gifti support
rmarkello 4e735bb
[RF] Still very broken fixing fitmodels_direct
rmarkello 61b96ae
Merge remote-tracking branch 'upstream/master' into gifti
rmarkello 10ef6d7
[RF] niwrite --> filewrite, better gifti support
rmarkello 9785e42
Update csstepdata format as JSON
emdupre a4d9f5b
Remove currently unused imports for linting
emdupre e9994cd
Address review comments
emdupre b210d2b
Merge pull request #1 from emdupre/master
rmarkello 047242d
Patch errors
emdupre 07ebb15
Merge pull request #2 from emdupre/master
rmarkello bb7eb17
[DOC] Doc-strings galore! Very basic but a start
rmarkello 0e9e938
[RF] Addressed reviews and minor updates
rmarkello a784e86
[FIX] Needed order=F for when zcat data provided
rmarkello 4d76812
[FIX] Allow N-dimensional arrays in `utils.andb`
rmarkello 7f70268
[FIX] Unmask not retaining dtype
rmarkello b8b5957
[FIX] Bugs in selcomps for gifti/nifti
rmarkello ddafa7c
[FIX] Minor updates to doc-strings + names
rmarkello f9810ad
[FIX] float32 / float64 bug in `fitmodels_direct()`
rmarkello ef6c34d
[FIX] Address review comments for #22
rmarkello File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
data/ | ||
|
||
# Byte-compiled / optimized / DLL files | ||
__pycache__/ | ||
*.py[cod] | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
# emacs: -*- mode: python-mode; py-indent-offset: 4; tab-width: 4; indent-tabs-mode: nil -*- | ||
# ex: set sts=4 ts=4 sw=4 et: | ||
|
||
from .t2smap import (t2sadmap, optcom) | ||
from .t2smap import (t2sadmap, make_optcom) | ||
|
||
__all__ = [ | ||
't2sadmap', 'optcom'] | ||
't2sadmap', 'make_optcom'] |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason these variables were added back in ? Previously it was
beta, _, _, _ = np.linalg.lstsq(X, B)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No! And indeed, I think a more parsimonious solution than either of the above would probably be:
Not sure my rationale here, so I'll change it to reflect this.