-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Add Python version info #126
Conversation
- Specify minimum Python version in README. - Add Python version badges tied to PyPi to README and docs index page. - Make duecredit’s import warning sound more like a warning and less like an error.
Codecov Report
@@ Coverage Diff @@
## master #126 +/- ##
=======================================
Coverage 49.68% 49.68%
=======================================
Files 32 32
Lines 2037 2037
=======================================
Hits 1012 1012
Misses 1025 1025
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks great @tsalo! Thank you!!
Might be best to let someone else who knows the codebase better take a look before merging (even though I've approved the PR) but from a documentation point of view I think this is great!
@KirstieJane Thank you for reviewing! I'll wait until @emdupre has a chance to review the code itself (not that much is changed), but I think that the documentation is the most important aspect so I'm very glad that the result is readable. |
Thanks so much @tsalo ! I actually don't know if it works 3.7, too, now, but I'd imagine so ! Depending on how you feel about the need to check that, I have one suggestion: Can we have the badge and the README text match (i.e., either change to say "3.6, 3.7" in the badge or "= 3.6" in the text) ? |
I think it makes the most sense to include 3.7 in the Travis CI. I can do that in this PR. I don't know if PyPi automatically detects supported Python versions from CI or something, or if you have to manually specify, but you might have to change tedana's PyPi settings to support 3.7. That should update the badge. |
Awesome. Done. Thanks for finding that! |
Thanks for adding it in ! This LGTM -- merging 🎉 |
Closes #124.
Changes proposed in this pull request:
like an error.