Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Add Python version info #126

Merged
merged 7 commits into from
Sep 10, 2018
Merged

Conversation

tsalo
Copy link
Member

@tsalo tsalo commented Sep 9, 2018

Closes #124.

Changes proposed in this pull request:

  • Specify minimum Python version in README.
  • Add Python version badges tied to PyPi to README and docs index page.
  • Make duecredit’s import warning sound more like a warning and less
    like an error.

tsalo added 4 commits August 22, 2018 17:45
- Specify minimum Python version in README.
- Add Python version badges tied to PyPi to README and docs index page.
- Make duecredit’s import warning sound more like a warning and less
like an error.
@codecov
Copy link

codecov bot commented Sep 9, 2018

Codecov Report

Merging #126 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #126   +/-   ##
=======================================
  Coverage   49.68%   49.68%           
=======================================
  Files          32       32           
  Lines        2037     2037           
=======================================
  Hits         1012     1012           
  Misses       1025     1025
Impacted Files Coverage Δ
tedana/info.py 100% <ø> (ø) ⬆️
tedana/due.py 50% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb01d72...6a33fcc. Read the comment docs.

Copy link
Member

@KirstieJane KirstieJane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks great @tsalo! Thank you!!

Might be best to let someone else who knows the codebase better take a look before merging (even though I've approved the PR) but from a documentation point of view I think this is great!

@tsalo
Copy link
Member Author

tsalo commented Sep 9, 2018

@KirstieJane Thank you for reviewing! I'll wait until @emdupre has a chance to review the code itself (not that much is changed), but I think that the documentation is the most important aspect so I'm very glad that the result is readable.

@emdupre
Copy link
Member

emdupre commented Sep 9, 2018

Thanks so much @tsalo ! I actually don't know if it works 3.7, too, now, but I'd imagine so !

Depending on how you feel about the need to check that, I have one suggestion: Can we have the badge and the README text match (i.e., either change to say "3.6, 3.7" in the badge or "= 3.6" in the text) ?

@tsalo
Copy link
Member Author

tsalo commented Sep 9, 2018

I think it makes the most sense to include 3.7 in the Travis CI. I can do that in this PR.

I don't know if PyPi automatically detects supported Python versions from CI or something, or if you have to manually specify, but you might have to change tedana's PyPi settings to support 3.7. That should update the badge.

@emdupre
Copy link
Member

emdupre commented Sep 10, 2018

Thanks ! Happy to see it passes with 3.7 😄 I think you need to change this line to update it on PyPi (for the next release). As always, fmriprep has a good example here !

@tsalo
Copy link
Member Author

tsalo commented Sep 10, 2018

Awesome. Done. Thanks for finding that!

@emdupre
Copy link
Member

emdupre commented Sep 10, 2018

Thanks for adding it in ! This LGTM -- merging 🎉

@emdupre emdupre merged commit 0f0b1ee into ME-ICA:master Sep 10, 2018
@tsalo tsalo deleted the add-version-info branch September 10, 2018 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants