Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert text dumps to json format #28

Closed
emdupre opened this issue May 5, 2018 · 6 comments
Closed

Convert text dumps to json format #28

emdupre opened this issue May 5, 2018 · 6 comments
Labels
documentation issues related to improving documentation for the project

Comments

@emdupre
Copy link
Member

emdupre commented May 5, 2018

Comes from #24 (comment)

Right now, csstepdata is generated by evaluating variables and saving out the result to a text file. Something similar happens in seldict, although there the result is returned as a dictionary.

It would be great to instead zip together a list of the variables with descriptive identifiers. Then, if the dictionary is being saved out, we could use json.dumps() to write out a structured instead of plain text file.

@emdupre emdupre added mozsprint Issues highlighted for the 2018 Mozilla Global Sprint documentation issues related to improving documentation for the project labels May 5, 2018
@rmarkello
Copy link
Member

This was partially resolved with #22!

@emdupre
Copy link
Member Author

emdupre commented May 10, 2018

Yes, I realized in doing it that the issue with seldict is actually slightly different. I might be ok to close this for now and address seldict later as part of #16. WDYT ?

@rmarkello
Copy link
Member

That seems fine with me! I would, however, potentially consider raising a separate issue for reorganizing the comp_table.txt file generated via tedana.interfaces.tedana.writect() to something a bit more JSON-like, too?

@emdupre
Copy link
Member Author

emdupre commented May 10, 2018

Yes, I think that's fair. That might even be a more accurate description of this issue... seldict is coming up in #35 if I want to keep linting

@emdupre emdupre removed the mozsprint Issues highlighted for the 2018 Mozilla Global Sprint label May 28, 2018
@tsalo
Copy link
Member

tsalo commented Dec 3, 2018

This was originally about the component table format, right? Given that we're now using a csv format for those tables, should we close this?

@emdupre
Copy link
Member Author

emdupre commented Dec 3, 2018

Agreed ! Yes, this was still open if we wanted to use JSON instead, but that's overkill at this point I think. Closing :)

@emdupre emdupre closed this as completed Dec 3, 2018
handwerkerd pushed a commit to handwerkerd/tedana that referenced this issue Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to improving documentation for the project
Projects
None yet
Development

No branches or pull requests

3 participants