Miscellaneous improvements from Power replication #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #9 +/- ##
==========================================
- Coverage 21.19% 16.86% -4.34%
==========================================
Files 6 6
Lines 335 510 +175
==========================================
+ Hits 71 86 +15
- Misses 264 424 +160
Continue to review full report at Codecov.
|
This reverts commit f123fdb.
Currently we smooth analysis values and null distributions across distances *before* evaluating significance, which seems to me to enhance significance. This change calculates the rank for each edge against its own null distribution before averaging across distances. Basically, this shifts from averaging, then ranking, to ranking, then averaging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes None.
Changes proposed in this pull request: