Fix: Rework on acq2106_435st trigger selection. #2284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove new `TRIG_SRC` node Move functionality into existing `TRIG_MODE` node `TRIG_MODE` can now be * hard, soft * master:hard, solo:soft, etc * master:ext, solo:wrtt0, fpmaster:fp_sync, etc. Refactor .format() to % format Move `getUUT()` to parent 435st class (overridden in 435sc) Removed legacy `trig_types` Moved constants to class scope * MIN_FREQUENCY * TRIG_SRC_OPTS_0 * TRIG_SRC_OPTS_1 Removed initializing trigger sources to 'NONE' Should be set automatically by sync_role Wrap debug statements in `if self.debug`
joshStillerman
approved these changes
Apr 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove new
TRIG_SRCnodeMove functionality into existing
TRIG_MODEnodeTRIG_MODEcan now beRefactor .format() to % format
Move
getUUT()to parent 435st class (overridden in 435sc)Removed legacy
trig_typesMoved constants to class scope
Removed initializing trigger sources to 'NONE'
Should be set automatically by sync_role
Wrap debug statements in
if self.debug