Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response to JOSS feedback. #87

Merged
merged 19 commits into from
Apr 2, 2023
Merged

Response to JOSS feedback. #87

merged 19 commits into from
Apr 2, 2023

Conversation

orionarcher
Copy link
Collaborator

@orionarcher orionarcher commented Mar 7, 2023 •
edited
Loading

Description

A response to @arose feedback

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Add citation to nglview
  • Update tutorials to remove hard paths
  • Add rdkit and plotly as dependencies in setup.py and requirements.txt
  • Update documentation to better show available properties

Status

  • Ready to go

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@orionarcher orionarcher mentioned this pull request Mar 7, 2023
Closed
@codecov
Copy link

codecov bot commented Mar 7, 2023 •
edited
Loading

Codecov Report

Merging #87 (9b96772) into main (9461f84) will decrease coverage by 0.30%.
The diff coverage is 94.80%.

Additional details and impacted files

@orionarcher orionarcher merged commit de4afd4 into MDAnalysis:main Apr 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@orionarcher