Issue#902 #908
Merged
Issue#902 #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed extra rewind methods, force all readers to follow base implementation
|
looks good to me if everything passes |
|
This should be taken into account in #868. |
|
Since the test pass for xtc as well I assume this is fine. |
abiedermann
pushed a commit
to abiedermann/mdanalysis
that referenced
this pull request
Oct 26, 2016
unify rewind behavior of Readers, fix MDAnalysis#902
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #902
Changes made in this Pull Request:
base.Reader.rewindbehaviourThis does mean that XDR does reopen the file rather than simply seek backwards (a backwards step for #871) but at least it's uniform starting point now.
PR Checklist
[ ] Tests?n/a already covered[ ] Docs?[ ] CHANGELOG updated?external behaviour not changedRemoved extra rewind methods, force all readers to follow base
implementation