Updated LICENSE and AUTHOR info regarding xdrfile (closes #679) #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -34,6 +34,7 @@ Enhancement | |||
|
|
|||
| Changes | |||
|
|
|||
| * xdrlib was rebranded limdaxdr. (Issue #679) | |||
|
@mnmelo you forgot to add the renamed c-file. This is the reason the minimal build fails. The full build fails because you didn't change the offsets detection code in |
|
Ouch... That was a sloppy rebasing I made. And dumb to have skipped libmdaxdr.c (had just finished working on skipping the cythonized files). |
|
Overall looks good to me, thanks for doing the legalese. |
Rebranded our xdrlib with cython bindings as libmdaxdr. Further standardized XDR error message reporting and exceptions (now mostly IOError). Removed reference to the old SWIG numpy.i in the credits. Made logo LICENSE info consistent
mnmelo
force-pushed
the
issue-679-xdr_licenseinfo
branch
from
c3b838f
to
2a48d50
Compare
kain88-de
added a commit
that referenced
this pull request
Feb 8, 2016
Updated LICENSE and AUTHOR info regarding xdrfile (closes #679)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebranded our xdrlib with cython bindings as libmdaxdr.
Further standardized XDR error message reporting and exceptions
(now mostly IOError).
Removed reference to the old SWIG numpy.i in the credits.
Made logo LICENSE info consistent