Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix error message for XDR readers #4231

Merged
merged 9 commits into from
Aug 11, 2023
Merged

fix error message for XDR readers #4231

merged 9 commits into from
Aug 11, 2023

Commits on Aug 10, 2023

  1. fix error message for XDR readers

    - error message for not being able to write lockfile did not insert the filename into
      message: fixed by using proper f string
    - changed all .format to modern f string in XDR.py
    - add explicit test for offsets_filename()
    - add additional pytest.warns() to tests to catch warnings (reduces warnings output and
      checks that all expected warnings are raised with proper messages)
    orbeckst committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    dc10474 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4f18afb View commit details
    Browse the repository at this point in the history
  3. Apply suggestions from code review

    Co-authored-by: Irfan Alibay <IAlibay@users.noreply.github.com>
    orbeckst and IAlibay authored Aug 10, 2023
    Configuration menu
    Copy the full SHA
    9b0c1c9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    997e15c View commit details
    Browse the repository at this point in the history
  5. Merge branch 'fix-xdr-errormessages' of github.com:MDAnalysis/mdanaly…

    …sis into fix-xdr-errormessages
    orbeckst committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    fd4fe34 View commit details
    Browse the repository at this point in the history
  6. more explicit warnings testing

    - reduces warnings in test_xdr down to 2 (both related to del)
    - test for empty selection and missing elements warnings
    - rewriting more old-school parameter interpolation to f strings
    orbeckst committed Aug 10, 2023
    Configuration menu
    Copy the full SHA
    4f8be63 View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2023

  1. only use f-strings where used

    Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
    orbeckst and RMeli authored Aug 11, 2023
    Configuration menu
    Copy the full SHA
    f995b31 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    874d9ba View commit details
    Browse the repository at this point in the history
  3. Merge branch 'fix-xdr-errormessages' of github.com:MDAnalysis/mdanaly…

    …sis into fix-xdr-errormessages
    orbeckst committed Aug 11, 2023
    Configuration menu
    Copy the full SHA
    593aa9f View commit details
    Browse the repository at this point in the history