Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update numpy in pyproject.toml #4227

Merged
merged 1 commit into from
Aug 9, 2023
Merged

Update numpy in pyproject.toml #4227

merged 1 commit into from
Aug 9, 2023

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Aug 8, 2023

Looks like we forgot to bump up the numpy version in the pyproject.toml? setup.py is fine.

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

Developers certificate of origin


📚 Documentation preview 📚: https://mdanalysis--4227.org.readthedocs.build/en/4227/

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Linter Bot Results:

Hi @IAlibay! Thanks for making this PR. We linted your code and found the following:

There are currently no issues detected! 🎉

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (2bf55dd) 93.62% compared to head (e193fa7) 93.62%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #4227   +/-   ##
========================================
  Coverage    93.62%   93.62%           
========================================
  Files          193      193           
  Lines        25295    25295           
  Branches      4063     4063           
========================================
  Hits         23683    23683           
  Misses        1096     1096           
  Partials       516      516           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IAlibay
Copy link
Member Author

IAlibay commented Aug 9, 2023

I'm just going to self-merge here, I need to get on with other things.

@IAlibay IAlibay merged commit 072209f into develop Aug 9, 2023
26 checks passed
@IAlibay IAlibay deleted the numpy-pyproject-nep29 branch August 9, 2023 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant