Switch to scientifc python nightly package location for cron tests against upstream nightly wheels #4203
Conversation
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## develop #4203 +/- ##
===========================================
+ Coverage 93.61% 93.62% +0.01%
===========================================
Files 193 193
Lines 25174 25295 +121
Branches 4060 4063 +3
===========================================
+ Hits 23566 23683 +117
- Misses 1092 1096 +4
Partials 516 516 ☔ View full report in Codecov by Sentry. |
| @@ -786,7 +786,7 @@ PyConverter_AnyDoubleArray( | |||
| PyObject **address) | |||
| { | |||
| PyArrayObject *obj = (PyArrayObject *)object; | |||
| if (PyArray_Check(object) && obj->descr->type_num == PyArray_DOUBLE) { | |||
| if (PyArray_Check(object) && obj->descr->type_num == NPY_DOUBLE) { | |||
There was a problem hiding this comment.
@hmacdope or @richardjgowers - am I correct in thinking that this is an acceptable replacement for the now removed PyArray_DOUBLE?
There was a problem hiding this comment.
Looks correct to me, there is even a tools/replace_old_macros.sed in the NumPy repo that does what you did.
|
We can't say if we're fully compatible with the current numpy 2.0-dev until #4198 is merged, but at least this gets us back to properly testing against nightly upstream. |
|
pinging @MDAnalysis/coredevs - would be great to get our cron checks working again |
|
This is stalling us from going green on CRON CI - I'm going to reask for a review @MDAnalysis/coredevs |
| @@ -786,7 +786,7 @@ PyConverter_AnyDoubleArray( | |||
| PyObject **address) | |||
| { | |||
| PyArrayObject *obj = (PyArrayObject *)object; | |||
| if (PyArray_Check(object) && obj->descr->type_num == PyArray_DOUBLE) { | |||
| if (PyArray_Check(object) && obj->descr->type_num == NPY_DOUBLE) { | |||
There was a problem hiding this comment.
Looks correct to me, there is even a tools/replace_old_macros.sed in the NumPy repo that does what you did.
|
Thanks @tylerjereddy ! |
Fixes #4202
Changes made in this Pull Request:
PR Checklist
📚 Documentation preview 📚: https://mdanalysis--4203.org.readthedocs.build/en/4203/