-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pin sphinx <7.0, docutils <0.18 #4196
Conversation
Linter Bot Results:Hi @lilyminium! Thanks for making this PR. We linted your code and found the following: There are currently no issues detected! 🎉 |
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## develop #4196 +/- ##
========================================
Coverage 93.61% 93.61%
========================================
Files 193 193
Lines 25170 25170
Branches 4059 4059
========================================
Hits 23562 23562
Misses 1092 1092
Partials 516 516 ☔ View full report in Codecov by Sentry. |
I run into this too recently (RMeli/spyrmsd#77); the RTD theme is not compatible with |
Thanks @RMeli! Yeah I was surprised that RTD wasn't also failing with that error. Turns out it seems to defualt to sphinx 5.0.2 anyway: https://readthedocs.org/api/v2/build/21298747.txt and https://readthedocs.org/api/v2/build/21305166.txt. It's still suitably messed I think I might have tracked it down to docutils updating to 0.18.1! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The one question but otherwise I'll approve.
Fixes #4177, #4194
Changes made in this Pull Request:
PR Checklist
📚 Documentation preview 📚: https://mdanalysis--4196.org.readthedocs.build/en/4196/