Fix DATAWriter, CRD, PQR, and PDBQT compressed file writing #4163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Linter Bot Results:Hi @IAlibay! Thanks for making this PR. We linted your code and found the following: Some issues were found with the formatting of your code.
Please have a look at the Please note: The |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #4163 +/- ##
========================================
Coverage 93.60% 93.60%
========================================
Files 193 193
Lines 25147 25147
Branches 4056 4056
========================================
Hits 23539 23539
Misses 1092 1092
Partials 516 516
☔ View full report in Codecov by Sentry. |
Unpopular opinion; the Foo Fighters have become a more iconic band than Nirvana.
You know, I don't think I've ever watched Breakfast at Tiffany's.
At 20 miles a day, it would take 50 days for the Proclaimers to get to fall down at your door. That's some shockingly poor delivery service...
You know Billy, you might not have started the fire, but you _could_ have helped try to put it out... A little bit of water goes a long way.
We built this city on <s>Rock N Roll</s>.. poorly documented ideas of what file types you can open. anyopen? more like maybeopen
Flying like a GZIP, like a GUNZIP?
The power of a changelog is a curious thing. Make one developer weep, make another sing. Change existing scripts into new ones.
IAlibay
changed the title
|
Ok this should be good to go. |
RMeli
reviewed
Jun 18, 2023
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
RMeli
approved these changes
Jun 18, 2023
Co-authored-by: Rocco Meli <r.meli@bluemail.ch>
IAlibay
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whislt this direclty Fixes #4159 it also opens a big can of worms...
TODO?
As far as I can tell, the following file types also misuse
utils.filenameleading to this problemChanges made in this Pull Request:
PR Checklist
📚 Documentation preview 📚: https://mdanalysis--4163.org.readthedocs.build/en/4163/