Updated test_encore.py

[v-parmar]

Fixed #3695

Updated test_encore.py file.
Updated 'rmsd' attribute with 'results.rmsd' and 'rmsf' with 'results.rmsf' in test_encore.py file.

[github-actions]

Hello there first time contributor! Welcome to the MDAnalysis community! We ask that all contributors abide by our Code of Conduct and that first time contributors introduce themselves on the developer mailing list so we can get to know you. You can learn more about participating here. Please also add yourself to package/AUTHORS as part of this PR.

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (4e3ea0e) 93.53% compared to head (861e1e7) 93.53%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #4032   +/-   ##
========================================
  Coverage    93.53%   93.53%           
========================================
  Files          191      191           
  Lines        25063    25063           
  Branches      4042     4042           
========================================
  Hits         23443    23443           
  Misses        1099     1099           
  Partials       521      521           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[RMeli]

Thank you for the PR @v-parmar. As you can see, the "linters" checks are not successful. You need to format the code properly in order for them to pass.

Also, since you are a first time contributor, you need to add your name to the package/AUTHORS file, as well as your GitHub handle to package/CHANGELOG.

Finally, this PR solves the issue for test_encore.py. Have you checked if the same happens for other tests, as suggested by @orbeckst in #3695 (comment)?

[RMeli]

Thanks @v-parmar. There are now conflicts in package/CHANGELOG that need to be solved.

Finally, this PR solves the issue for test_encore.py. Have you checked if the same happens for other tests, as suggested by @orbeckst in #3695 (comment)?

Can you please confirm if you have checked this?

[v-parmar]

Thanks @v-parmar. There are now conflicts in package/CHANGELOG that need to be solved.

Finally, this PR solves the issue for test_encore.py. Have you checked if the same happens for other tests, as suggested by @orbeckst in #3695 (comment)?

Can you please confirm if you have checked this?

Yes, I have checked.

[RMeli]

@v-parmar unfortunately the way you changed the CHANGELOG is not quite right. You need to add your GitHub handle alongside the handles of other developers, for the 2.5.0 release. The ??/??/?? is just a placeholder for the date of the release, which will be updated during the release process.

Please move your GitHub handle and the description of the change to the appropriate place. Only the description under "Fixes" is needed for this PR.

You will likely get back the conflicts you were having before, that you will need to fix. You can use the GitHub Web interface to solve conflicts. See addressing merge conflicts for more details.

[RMeli]

Thanks @v-parmar , LGTM!