Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AuxReader for EDR Files #3749
AuxReader for EDR Files #3749
Changes from 3 commits
f24d296
0906225
a7c1a81
485b5d8
1048271
0b49bad
e0767b4
0f7b1af
4f944b3
ca1a014
54022bf
a7f27b1
ca39385
6159f2d
f228aa7
73143f6
3be01c6
46584ab
0733647
77d8fa1
3105f0e
b2f30e3
f48c74c
1f921ea
9152604
f59e6fa
b29747c
3916bdf
0092d34
9235600
08907c3
e78ab9e
0119ee1
c233970
cccc1fd
aa226ca
d77517b
fed3b06
ed20993
cea6a97
3660770
1a0f4e3
117d138
c7bde96
55a794a
5e7a779
dfaba25
d1892f6
c5a3a7c
2cc8390
88c4651
8b71850
d599e97
e8f5998
336cc80
a62066e
0ad0079
064ab37
e256498
8d9e077
11c3924
e3a2bb8
828b2dc
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From the
__init__
signature?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, yes... Need to change the docstring here in general still, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd omit
~
so that it's clear that you're looking at the base.AuxStepThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably should go ahead and add type hints here as you go along
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As you know I've barely been able to say words today, a .edr file or an .edr file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say "from a .edr file", but "from an EDR file", but that's because I say "dot edr" in my mind
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
an edr file for mine sorry to be a PITA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, here and everywhere else, should we just be using
EDR_
instead?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Personally, I'm not sure the entry in the GROMACS manual is interesting or helpful enough to keep linking to it every time the format is mentioned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't use the
~
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please elaborate based on the memory warning stuff
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will give you the same thing and resolve ~ 200 ns faster on my laptop?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh that's much better, thank you!