Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove py2 things from coordinates & topology #2759

Merged
merged 3 commits into from
Jun 16, 2020

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jun 15, 2020

Towards #2541

Changes made in this Pull Request:

  • Removes py2 things (six/future) from coordinates and topology

PR Checklist

  • Tests?
  • Docs? N/A
  • CHANGELOG updated? N/A
  • Issue raised/referenced?

@IAlibay IAlibay added the remove-2.0 deprecated in 1.0 and to be removed in 2.0 label Jun 15, 2020
@codecov
Copy link

codecov bot commented Jun 15, 2020

Codecov Report

Merging #2759 into develop will decrease coverage by 0.04%.
The diff coverage is 67.44%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2759      +/-   ##
===========================================
- Coverage    91.14%   91.09%   -0.05%     
===========================================
  Files          176      177       +1     
  Lines        23711    23692      -19     
  Branches      3119     3122       +3     
===========================================
- Hits         21611    21582      -29     
- Misses        1480     1490      +10     
  Partials       620      620              
Impacted Files Coverage Δ
package/MDAnalysis/coordinates/DLPoly.py 95.20% <ø> (-0.06%) ⬇️
package/MDAnalysis/coordinates/DMS.py 88.40% <ø> (-0.17%) ⬇️
package/MDAnalysis/coordinates/GMS.py 85.61% <ø> (-0.10%) ⬇️
package/MDAnalysis/coordinates/GSD.py 86.66% <0.00%> (-0.57%) ⬇️
package/MDAnalysis/coordinates/INPCRD.py 90.32% <ø> (-0.59%) ⬇️
package/MDAnalysis/coordinates/MMTF.py 100.00% <ø> (ø)
package/MDAnalysis/coordinates/PDBQT.py 84.37% <ø> (-0.17%) ⬇️
package/MDAnalysis/coordinates/ParmEd.py 83.33% <ø> (-0.10%) ⬇️
package/MDAnalysis/coordinates/TXYZ.py 90.00% <0.00%> (-0.33%) ⬇️
package/MDAnalysis/coordinates/__init__.py 100.00% <ø> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da72d55...a71e67a. Read the comment docs.

@richardjgowers richardjgowers merged commit 0d951a2 into MDAnalysis:develop Jun 16, 2020
PicoCentauri pushed a commit to PicoCentauri/mdanalysis that referenced this pull request Mar 30, 2021
* Removes py2 things from coordinates

* Removes py2 things from coordinate tests

* Removes py2 things from topology
@1ut 1ut mentioned this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component-Topology maintainability remove-2.0 deprecated in 1.0 and to be removed in 2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants