Remove py2 things from lib #2752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IAlibay
commented
Jun 13, 2020
package/MDAnalysis/lib/util.py
Outdated
| @@ -438,7 +435,7 @@ def _get_stream(filename, openfunction=open, mode='r'): | |||
| # case we have to ignore the error and return None. Second is when openfunction can't open the file because | |||
| # either the file isn't there or the permissions don't allow access. | |||
| if errno.errorcode[err.errno] in ['ENOENT', 'EACCES']: | |||
| six.reraise(*sys.exc_info()) | |||
| raise sys.exc_info()[0](sys.exc_info()[1]) from err | |||
There was a problem hiding this comment.
I'm not sure this is the right conversion here, any input would be appreciated
4 tasks
Codecov Report
@@ Coverage Diff @@
## develop #2752 +/- ##
===========================================
- Coverage 91.25% 91.07% -0.18%
===========================================
Files 176 177 +1
Lines 23967 23655 -312
Branches 3153 3122 -31
===========================================
- Hits 21871 21544 -327
- Misses 1470 1490 +20
+ Partials 626 621 -5
Continue to review full report at Codecov.
|
lilyminium
requested changes
Jun 14, 2020
|
I didn't update CHANGELOG in #2750. I guess if we did it would go in Deprecations? |
Spoke to @richardjgowers off-github, and his take on this was that changelog changes for this won't be necessary (my bad, should have removed my question yesterday). |
lilyminium
approved these changes
Jun 16, 2020
Co-authored-by: Lily Wang <31115101+lilyminium@users.noreply.github.com>
PicoCentauri
pushed a commit
to PicoCentauri/mdanalysis
that referenced
this pull request
Mar 30, 2021
- remove six and __future__ imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2541
Changes made in this Pull Request:
Question:
Do we want changelog entries for these things?PR Checklist