improved unknown attribute errors in atomgroup and atom classes #2573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemanj
reviewed
Mar 1, 2020
There was a problem hiding this comment.
There are several issues with this PR.
- It solves parts of the problem but does not differentiate between generally valid but unavailable versus really unknown properties.
- The particular cases of the
AtomGroupproperties'fragments', 'fragindices', 'n_fragments', 'unwrap', and, likewise, theAtomproperties'fragment', 'fragindex'need special care, because these are attributes/methods which are generated based on the topology containing bond information. Thus, it doesn't make sense to say that these attributes are missing from the topology because the error is actually due to missing information about bonds.
|
@zemanj , when you take the time to review (thank you!!) and you find that the PR is not ready to be merged, make it a "request changes" instead of a neutral comment as this sends a much clearer message. Especially for GSoC, we want to communicate clearly with the students. They should ask for clarification if anything is unclear or if they don't know how to move forward. |
|
Ok, thanks for the context. Makes sense.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2565
Changes made in this Pull Request:
Changed error message when an unknown attribute/method is accessed.
PR Checklist