Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes LAMMPSDataConverter #2569

Merged
merged 3 commits into from
Feb 29, 2020
Merged

Removes LAMMPSDataConverter #2569

merged 3 commits into from
Feb 29, 2020

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Feb 29, 2020

Fixes #2564
Towards v1.0 #2443

Changes made in this Pull Request:

  • Removes deprecated :class:LAMMPSDataConverter.

PR Checklist

  • Tests? (weren't any for it)
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@codecov
Copy link

codecov bot commented Feb 29, 2020

Codecov Report

Merging #2569 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2569   +/-   ##
========================================
  Coverage    90.69%   90.69%           
========================================
  Files          170      170           
  Lines        22860    22860           
  Branches      2944     2944           
========================================
  Hits         20733    20733           
  Misses        1540     1540           
  Partials       587      587

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2557414...f885199. Read the comment docs.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, reading some of the comments of the removed code was a blast from the past ;-)

@orbeckst orbeckst merged commit 7efc83d into MDAnalysis:develop Feb 29, 2020
@IAlibay IAlibay deleted the issue-2564 branch February 29, 2020 22:49
lilyminium pushed a commit to lilyminium/mdanalysis that referenced this pull request Mar 4, 2020
* Fixes MDAnalysis#2564
* Removes deprecated LAMMPSDataConverter class
* Fixes docstring order.
@fiona-naughton fiona-naughton added maintainability deprecation Deprecated functionality to give advance warning for API changes. labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecated functionality to give advance warning for API changes. maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

LAMMPSDataConverter deprecated with no target for removal
3 participants