Removes skip and format from DCD reader #2501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2501 +/- ##
========================================
Coverage 90.23% 90.23%
========================================
Files 169 169
Lines 23220 23220
Branches 3008 3008
========================================
Hits 20952 20952
Misses 1661 1661
Partials 607 607Continue to review full report at Codecov.
|
richardjgowers
approved these changes
Feb 5, 2020
fiona-naughton
added
maintainability
deprecation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2443
Changes made in this Pull Request:
skipandformatkeywords from :meth:DCDReader.timeseries.PR Checklist