Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FullGroup selection keyword removal #2500

Merged
merged 4 commits into from
Feb 5, 2020

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Feb 4, 2020

Completes #268

Changes made in this Pull Request:

  • Removes the fullgroup keyword from selections (and related test).

PR Checklist

  • Tests?
  • Docs?
  • CHANGELOG updated?
  • Issue raised/referenced?

@IAlibay
Copy link
Member Author

IAlibay commented Feb 4, 2020

So the test removal wasn't necessary since it was just testing that an error would occur, so if we want I can always add it back in.

@IAlibay IAlibay mentioned this pull request Feb 4, 2020
6 tasks
@codecov
Copy link

codecov bot commented Feb 4, 2020

Codecov Report

Merging #2500 into develop will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2500      +/-   ##
===========================================
+ Coverage    90.25%   90.25%   +<.01%     
===========================================
  Files          169      169              
  Lines        23225    23217       -8     
  Branches      3009     3010       +1     
===========================================
- Hits         20962    20955       -7     
+ Misses        1656     1655       -1     
  Partials       607      607
Impacted Files Coverage Δ
package/MDAnalysis/core/groups.py 98.24% <ø> (ø) ⬆️
package/MDAnalysis/core/selection.py 99.48% <ø> (+0.15%) ⬆️
package/MDAnalysis/analysis/density.py 65.45% <0%> (+0.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c03a2f...3868fef. Read the comment docs.

@richardjgowers richardjgowers merged commit 1d5ec02 into MDAnalysis:develop Feb 5, 2020
@IAlibay IAlibay deleted the fullgroup-removal branch June 6, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants