Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes stubs files for v1.0 #2481

Merged
merged 6 commits into from
Jan 30, 2020

Conversation

IAlibay
Copy link
Member

@IAlibay IAlibay commented Jan 29, 2020

Partly addresses #2443 comment

Changes made in this Pull Request:
Removed:

  • core/distances.py
  • core/log.py
  • core/parallel.py
  • core/qcprot.py
  • core/transformations.py
  • core/units.py
  • core/utils.py
  • core/KDTree.py
  • analysis/x3dna.py

To add:

  • test_deprecated.py
  • tests in test_transformation.py

PR Checklist

  • Tests? (as far as I am aware no new tests are needed here)
  • Docs? (added in utils/test_transformation.py)
  • CHANGELOG updated?
  • Issue raised/referenced?

@IAlibay IAlibay changed the title [WIP] Removes core files for v1.0 [WIP] Removes stubs files for v1.0 Jan 29, 2020
@IAlibay IAlibay changed the title [WIP] Removes stubs files for v1.0 Removes stubs files for v1.0 Jan 29, 2020
@IAlibay IAlibay mentioned this pull request Jan 29, 2020
6 tasks
@codecov
Copy link

codecov bot commented Jan 29, 2020

Codecov Report

Merging #2481 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #2481   +/-   ##
========================================
  Coverage    90.25%   90.25%           
========================================
  Files          169      169           
  Lines        23219    23219           
  Branches      3009     3009           
========================================
  Hits         20956    20956           
  Misses        1656     1656           
  Partials       607      607

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5599d0c...0a194bc. Read the comment docs.

@richardjgowers richardjgowers merged commit 53f0b0f into MDAnalysis:develop Jan 30, 2020
@IAlibay IAlibay deleted the core-removals-v1 branch January 30, 2020 10:24
@fiona-naughton fiona-naughton added maintainability deprecation Deprecated functionality to give advance warning for API changes. labels Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecated functionality to give advance warning for API changes. maintainability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants